Refactor newly added ped functions to use the new parser #1484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qaisjp
force-pushed
the
refactor/np/pedDefs
branch
from
80313f9 to
d9266de
Compare
qaisjp
force-pushed
the
refactor/np/pedDefs
branch
from
d9266de to
5f75834
Compare
|
I think this can be merged? @qaisjp Edit: actually, I see. There's new a hard error instead of a silent fail now. |
qaisjp
reviewed
Jun 1, 2020
qaisjp
force-pushed
the
refactor/np/pedDefs
branch
from
06353c3 to
b6271c3
Compare
qaisjp
approved these changes
Jun 1, 2020
StrixG
approved these changes
Jun 2, 2020
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry picked from #1454